fix: refuse to read directories

src/core/read-pull-stream.js

@@ -4,6 +4,7 @@ const exporter = require('ipfs-unixfs-engine').exporter
 const pull = require('pull-stream/pull')
 const collect = require('pull-stream/sinks/collect')
 const waterfall = require('async/waterfall')
+const UnixFs = require('ipfs-unixfs')
 const {
   traverseTo
 } = require('./utils')
@@ -30,9 +31,16 @@ module.exports = (ipfs) => {
         parents: false
       }, done),
       (result, done) => {
+        const node = result.node
+        const meta = UnixFs.unmarshal(node.data)
+
+        if (meta.type !== 'file') {
+          return done(new Error(`Error: ${path} was not a file`))
+        }
+
         waterfall([
           (next) => pull(
-            exporter(result.node.multihash, ipfs._ipld, {
+            exporter(node.multihash, ipfs._ipld, {
               offset: options.offset,
               length: options.length
             }),

test/read.spec.js

@@ -145,6 +145,15 @@ describe('read', function () {
           .then((result) => method.collect(result))
           .then((buffer) => expect(buffer).to.deep.equal(data.slice(offset, offset + length)))
       })
+
+      it('refuses to read a directory', () => {
+        const path = '/'
+
+        return method.read(path)
+          .catch(error => {
+            expect(error.message).to.contain('was not a file')
+          })
+      })
     })
   })
 })