Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Commit

Permalink
fix: override node-fetch version (#3835)
Browse files Browse the repository at this point in the history
We need the fix from node-fetch/node-fetch#1172
in node-fetch otherwise we can't detect when the other end of a streaming
response closes the connection.

At the moment we're using a fork of node-fetch with this patch applied
but the npm7 depdending hoisting algorithm hoists the wrong version so
here we add a dep to the root package.json to ensure we get the right
one.

This should only affect development and not published versions.  We can
revert this and switch to undici when node 16 becomes lts at the end
of October.
  • Loading branch information
achingbrain authored Aug 26, 2021
1 parent 6ad2b40 commit 30281db
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
},
"devDependencies": {
"lerna": "^3.22.0",
"node-fetch": "npm:@achingbrain/node-fetch@^2.6.4",
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2"
},
Expand Down

0 comments on commit 30281db

Please sign in to comment.