Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Commit

Permalink
add travis config;
Browse files Browse the repository at this point in the history
  • Loading branch information
@daviddias
daviddias committed Dec 10, 2015
1 parent c24f576 commit 35eb22d
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
language: node_js
node_js:
- "4"
- "5"

branches:
only:
- master

before_install:
- npm i -g npm
# Workaround for a permissions issue with Travis virtual machine images

This comment has been minimized.

Sign in to view

Copy link
@ralphtheninja

ralphtheninja Dec 10, 2015

What kind of problems are you having?

This comment has been minimized.

Sign in to view

Copy link
@daviddias

daviddias Dec 10, 2015

Author Member

to be honest, I've been using this travis config for such a long time that I don't even remember the problem that was there in the beginning. However, when using Node.js 4, we get npm 2 packaged and it gets weird for some dependencies (for example ipfs/station has to have its dependencies installed with npm 3 )

This comment has been minimized.

Sign in to view

Copy link
@ralphtheninja

ralphtheninja Dec 11, 2015

I just tried installing station using npm 2 and that works just fine on my machine. I think you should try to relax the requirements of needing npm@3 for a couple of reasons:

  • Most users are running node < 5 and are therefore using npm 2 by default and if they can install using npm 2 it will reduce friction and help a lot with adoption
  • npm 3 is super slow (not exactly sure why). Installing station using npm 3 takes 2 mins and 28 seconds on my machine, while it takes 1 min 13 seconds using npm 2.14.7, this is a pain for users and maybe even more pain for devs, wiping node_modules and reinstalling is something you often do and longer install times means frustrated devs and longer turn around times

I can help out with these simple devops things, just ping me :)

This comment has been minimized.

Sign in to view

Copy link
@daviddias

daviddias Dec 11, 2015

Author Member

You are able to run station with the modules installed through npm2? There have been some people having trouble ipfs/ipfs-desktop#56 (comment)

yes, please, your help would be greatly appreciated to get all of these things consistent across repos, totally buy in for less friction! thank you @ralphtheninja :)

This comment has been minimized.

Sign in to view

Copy link
@ralphtheninja

ralphtheninja Dec 11, 2015

You are able to run station with the modules installed through npm2? There have been some people having trouble ipfs/ipfs-desktop#56 (comment)

Well, I was at first. Then I switched to npm 3 and then npm start doesn't show the electron window, switched back to npm 2 but seems I can't run electron at all now. Let me test some more and take it to the station repo instead of discussing in this thread :)

This comment has been minimized.

Sign in to view

Copy link
@jbenet

jbenet Dec 11, 2015

Member

yes please! help to debug all the station things and shipping will be super useful.

cc @dignifiedquire
script:
- npm test

0 comments on commit 35eb22d

Please sign in to comment.