fix(dag): check dag.put options for plain object (#1480)

* fix(dag): check dag.put options for plain object fixes #1479 * fix(dag): check for undefined options value * fix: increase timeout for pin after hook License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ipfs · Aug 8, 2018 · d0b671b · d0b671b
1 parent ff59a2f
commit d0b671b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/core/components/dag.js b/src/core/components/dag.js
@@ -11,11 +11,13 @@ module.exports = function dag (self) {
     put: promisify((dagNode, options, callback) => {
       if (typeof options === 'function') {
         callback = options
-      } else if (options.cid && (options.format || options.hashAlg)) {
+        options = {}
+      } else if (options && options.cid && (options.format || options.hashAlg)) {
         return callback(new Error('Can\'t put dag node. Please provide either `cid` OR `format` and `hashAlg` options.'))
-      } else if ((options.format && !options.hashAlg) || (!options.format && options.hashAlg)) {
+      } else if (options && ((options.format && !options.hashAlg) || (!options.format && options.hashAlg))) {
         return callback(new Error('Can\'t put dag node. Please provide `format` AND `hashAlg` options.'))
       }
+      options = options || {}
 
       const optionDefaults = {
         format: 'dag-cbor',

diff --git a/test/core/pin.js b/test/core/pin.js
@@ -81,7 +81,10 @@ describe('pin', function () {
     })
   })
 
-  after(done => ipfs.stop(done))
+  after(function (done) {
+    this.timeout(20 * 1000)
+    ipfs.stop(done)
+  })
 
   describe('isPinnedWithType', function () {
     beforeEach(function () {