fix: resolve when value is a CID or a {'/': 'string cid'}

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

.aegir.js

@@ -15,7 +15,7 @@ module.exports = {
   },
   karma: {
     files: [{
-      pattern: 'node_modules/interface-ipfs-core/js/test/fixtures/**/*',
+      pattern: 'node_modules/interface-ipfs-core/test/fixtures/**/*',
       watched: false,
       served: true,
       included: false

package.json

@@ -68,7 +68,7 @@
     "execa": "^1.0.0",
     "form-data": "^2.3.3",
     "hat": "0.0.3",
-    "interface-ipfs-core": "~0.96.0",
+    "interface-ipfs-core": "^0.97.0",
     "ipfsd-ctl": "~0.41.0",
     "libp2p-websocket-star": "~0.10.2",
     "ncp": "^2.0.0",

src/core/components/resolve.js

@@ -34,15 +34,16 @@ module.exports = (self) => {
 
     const path = split.slice(3).join('/')
 
-    resolve(cid, path, (err, cid, remainder) => {
+    resolve(cid, path, (err, res) => {
       if (err) return cb(err)
-      cb(null, `/ipfs/${cidToString(cid, { base: opts.cidBase })}${remainder ? '/' + remainder : ''}`)
+      const { cid, remainderPath } = res
+      cb(null, `/ipfs/${cidToString(cid, { base: opts.cidBase })}${remainderPath ? '/' + remainderPath : ''}`)
     })
   })
 
   // Resolve the given CID + path to a CID.
   function resolve (cid, path, callback) {
-    let value, remainder
+    let value, remainderPath
     doUntil(
       (cb) => {
         self.block.get(cid, (err, block) => {
@@ -57,7 +58,7 @@ module.exports = (self) => {
           r.resolver.resolve(block.data, path, (err, result) => {
             if (err) return cb(err)
             value = result.value
-            remainder = result.remainderPath
+            remainderPath = result.remainderPath
             cb()
           })
         })
@@ -66,7 +67,11 @@ module.exports = (self) => {
         if (value && value['/']) {
           // If we've hit a CID, replace the current CID.
           cid = new CID(value['/'])
-          path = remainder
+          path = remainderPath
+        } else if (CID.isCID(value)) {
+          // If we've hit a CID, replace the current CID.
+          cid = value
+          path = remainderPath
         } else {
           // We've hit a value. Return the current CID and the remaining path.
           return true
@@ -77,7 +82,7 @@ module.exports = (self) => {
       },
       (err) => {
         if (err) return callback(err)
-        callback(null, cid, path)
+        callback(null, { cid, remainderPath: path })
       }
     )
   }

test/gateway/index.js

@@ -12,7 +12,7 @@ const path = require('path')
 const hat = require('hat')
 const fileType = require('file-type')
 
-const bigFile = loadFixture('js/test/fixtures/15mb.random', 'interface-ipfs-core')
+const bigFile = loadFixture('test/fixtures/15mb.random', 'interface-ipfs-core')
 const directoryContent = {
   'index.html': loadFixture('test/gateway/test-folder/index.html'),
   'nested-folder/hello.txt': loadFixture('test/gateway/test-folder/nested-folder/hello.txt'),