This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: accept objects in file.add #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Seems like it might be good to add a regression test for that, too. |
|
Adding test ipfs-inactive/interface-js-ipfs-core#234 |
|
Good catch! Can you check why CI isn't green too? |
|
@dryajov tested locally. It fails because js-ipfs-api has the same issue. I'm fixing it. |
|
verified locally and in some of the CI runs. hotfix incoming. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding back ability to pass objects to
files.add-{path: <string>, data: Buffer.from('hello')}. This regressed in 4b79066