Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix bug: node.files.add do not accept object #1255

Closed
wants to merge 1 commit into from

Conversation

tiagochen
Copy link

file: src\core\components\files.js
line: 199
api: add
problem: add api's param do not accept object, use Buffer instead

@JonKrone
Copy link
Contributor

JonKrone commented Mar 8, 2018

@tiagochen Thanks for the PR! And on the ipfs-101 example no less.

Would you please also update the README with these changes?

Also want to make sure @diasdavid is okay with the change from { path, content } to Buffer(content) rather than [ { path, content } ]. This example needs a change either way: #1256

@daviddias
Copy link
Member

This was a regression, fix here: #1257. My apologies for the troubles.

@daviddias daviddias closed this Mar 9, 2018
This was referenced Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants