This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: jsipfs add --only-hash (#1233) #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
* add --only-hash flag * skeleton http option passing, checkpoint commit to check some broken tests. * deep logging for debugging. Checkpoint * found the levledown problem! line endings! * add only-hash as a qs option for the send-files-stream. Also added some tests to help me figure that out * update --only-hash test, increase timeout for the afterAll hook. I think it takes longer because the --only-hash test leaves an unresolved ipfs.ls command. Would love to be able to cancel it :) * ipfs-exec/ipfs.fail should throw on a non-failing command && use random file for ipfs add --only-hash test. * fix an ipfs config test. * lint * clean: move test/http-api/extra/files.js to test/http-api/files.js
daviddias
commented
Mar 16, 2018
src/cli/commands/files/add.js
Outdated
| @@ -182,7 +188,8 @@ module.exports = { | |||
| strategy: argv.trickle ? 'trickle' : 'balanced', | |||
| shardSplitThreshold: argv.enableShardingExperiment ? argv.shardSplitThreshold : Infinity, | |||
| 'cid-version': argv['cid-version'], | |||
| 'raw-leaves': argv['raw-leaves'] | |||
| 'raw-leaves': argv['raw-leaves'], | |||
| onlyHash: argv['only-hash'] | |||
There was a problem hiding this comment.
it should be 'only-hash'
There was a problem hiding this comment.
I suggest we keep it onlyHash. cid-version and raw-leaves are the outlier here. There are many hyphenated options we convert to camelCase at the entry points of cli/http-api such as the above shardSplittingThreshold and dag --local-resolve, object --input-enc.
I can change raw-leaves and cid-version instead
There was a problem hiding this comment.
@JonKrone I like that. Go for it :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work from #1233