This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: jsipfs add --only-hash #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This PR needs ipfs-inactive/js-ipfs-http-client#700 to be released. Meanwhile, @JonKrone can you fix the merge conflicts? |
1 similar comment
|
This PR needs ipfs-inactive/js-ipfs-http-client#700 to be released. Meanwhile, @JonKrone can you fix the merge conflicts? |
|
Great. While waiting for ipfs-inactive/js-ipfs-http-client#700 to be in a release, I am working on ipfs/js-ipfsd-ctl#212 |
…me tests to help me figure that out
…ink it takes longer because the --only-hash test leaves an unresolved ipfs.ls command. Would love to be able to cancel it :)
…om file for ipfs add --only-hash test.
JonKrone
force-pushed
the
feat/only-hash
branch
from
85024ac
to
f326ca9
Compare
|
Update: This is ready as soon as the next release of ipfs-api is out :). Just needs a code review and CI rerun after that. |
|
Merging into the branch so that I can then update the deps. |
daviddias
pushed a commit
that referenced
this pull request
Mar 16, 2018
* add --only-hash flag * skeleton http option passing, checkpoint commit to check some broken tests. * deep logging for debugging. Checkpoint * found the levledown problem! line endings! * add only-hash as a qs option for the send-files-stream. Also added some tests to help me figure that out * update --only-hash test, increase timeout for the afterAll hook. I think it takes longer because the --only-hash test leaves an unresolved ipfs.ls command. Would love to be able to cancel it :) * ipfs-exec/ipfs.fail should throw on a non-failing command && use random file for ipfs add --only-hash test. * fix an ipfs config test. * lint * clean: move test/http-api/extra/files.js to test/http-api/files.js
daviddias
added a commit
that referenced
this pull request
Mar 17, 2018
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
* chore: update go-ipfs-dep * chore: build webworkers separately
This was referenced Jun 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables generating a would-be hash for content via http or cli:
jsips add --only-hash <file>,ipfs.add(<content>, { onlyHash: true })Turns out unix-fs-engine has been ready for this since ipfs-inactive/js-ipfs-unixfs-engine#183.
Depends on:
Related issues:
ipfs-inactive/js-ipfs-http-client#509
#1205