Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Repo version mismatch message confusing #1411

Closed
parkan opened this issue Jun 25, 2018 · 1 comment
Closed

Repo version mismatch message confusing #1411

parkan opened this issue Jun 25, 2018 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@parkan
Copy link
Contributor

parkan commented Jun 25, 2018

The go-ipfs error for old repo version is relatively helpful: ipfs repo needs migration

however, the js-ipfs error doesn't tell you what needs to be upgraded, for example here the user could easily think that their node version is the issue:

/Users/arkadiy/.nvm/versions/node/v6.5.0/lib/node_modules/ipfs/src/cli/utils.js:67
    throw err
    ^

Error: version mismatch: expected v6, found v5
    at get (/Users/arkadiy/.nvm/versions/node/v6.5.0/lib/node_modules/ipfs/node_modules/ipfs-repo/src/version.js:57:27)
    at store.get (/Users/arkadiy/.nvm/versions/node/v6.5.0/lib/node_modules/ipfs/node_modules/ipfs-repo/src/version.js:31:9)
    at /Users/arkadiy/.nvm/versions/node/v6.5.0/lib/node_modules/ipfs/node_modules/graceful-fs/graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:445:3)

as far as I can tell, repo upgrades in js are still an unsolved problem (#1071), but it's good to understand that the issue concerns the repo specifically -- would change the text to be more consistent with the go-ipfs message

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up labels Jun 27, 2018
@daviddias
Copy link
Member

Thanks for reporting this @parkan, totally agree that the help text is not super helpful. Fun thing is that for Node.js, you should be actually able to use the fs-repo-migrations from go as well. #1115 is just for when you are running in the Browser.

@daviddias daviddias added the status/ready Ready to be worked label Aug 25, 2018
steefmin added a commit to steefmin/js-ipfs-repo that referenced this issue Oct 3, 2018
steefmin added a commit to steefmin/js-ipfs-repo that referenced this issue Oct 4, 2018
jacobheun pushed a commit to ipfs/js-ipfs-repo that referenced this issue Oct 4, 2018
* fix: improved error message

ipfs/js-ipfs#1411

* fix: clarifies repo version mismatch error

* fix: linter error
@ghost ghost removed the status/ready Ready to be worked label Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

2 participants