Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Fails to start if preload is disabled #1514

Closed
travisperson opened this issue Aug 17, 2018 · 1 comment · Fixed by #1516
Closed

Fails to start if preload is disabled #1514

travisperson opened this issue Aug 17, 2018 · 1 comment · Fixed by #1516
Assignees
@alanshaw
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@travisperson
Copy link
Member

  • Version: v0.31.6
  • Platform: Linux black.travis.fyi 4.17.8-1-ARCH #1 SMP PREEMPT Wed Jul 18 09:56:24 UTC 2018 x86_64 GNU/Linux
  • Subsystem: start

Type: Bug

Severity:

Critical (High?)

Description:

When disabling the new preload feature, the node fails to start

/home/travis/src/github.com/ipfs/js-ipfs/src/core/components/start.js:46
        self._preload.start()
                      ^

TypeError: self._preload.start is not a function

Steps to reproduce the error:

'use strict'

const IPFS = require('ipfs')
const ipfs = new IPFS({
  config: {
    Addresses: {
      Swarm: []
    }
  },
  preload: {
    enabled: false,
  }
})
@jhiesey
Copy link

jhiesey commented Aug 18, 2018

I just ran into this as well. Looks like an easy fix though.

@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up labels Aug 18, 2018
@alanshaw alanshaw self-assigned this Aug 18, 2018
alanshaw added a commit that referenced this issue Aug 18, 2018
@alanshaw
fix: fails to start when preload disabled
1b33adb 
fixes #1514

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw alanshaw mentioned this issue Aug 18, 2018
Merged
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Aug 18, 2018
@ghost ghost removed the status/in-progress In progress label Aug 20, 2018
alanshaw added a commit that referenced this issue Aug 20, 2018
@alanshaw
fix: fails to start when preload disabled (#1516)
511ab47 
fixes #1514

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@fazo96 fazo96 mentioned this issue Aug 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fails to start when preload disabled ipfs/js-ipfs
3 participants
@alanshaw @travisperson @jhiesey