This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
--stream option support for ipfs.name.resolve? #2611
Assignees
Labels
exp/expert
Having worked on the specific codebase is important
kind/feature
P2
Medium: Good to have, but can wait until someone steps up
status/ready
Ready to be worked
Comments
alanshaw
added
exp/expert
8 tasks
alanshaw
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this issue
Jan 23, 2020
TLDR;
* Remove Node.js streams and pull streams
* Remove callbacks
* Remove `peer-info` and `peer-id`
---
Now that internals are all async/await/iterables and `fetch` the next step is to bubble up that goodness to the core API, removing the multiple stream APIs and removing callback support.
I'm also proposing removing `peer-info` and `peer-id`, since these drastically increase the bundle size by pulling in `libp2p-crypto`, for which 99% of it's capability is unused. In place of `peer-id` we return a `CID`, which can easily be converted to a `PeerId` instance via:
```js
const peerId = PeerId.createFromCID(peerCid)
```
In place of `peer-info` we return an object `{ id: CID, addrs: Multiaddr[] }`, which can easily be converted to a `PeerInfo` like:
```js
const peerInfo = new PeerInfo(PeerId.createFromCID(info.id))
info.addrs.forEach(addr => peerInfo.multiaddrs.add(addr))
```
refs ipfs/js-ipfs#1670
refs ipfs/js-ipfs#2611
refs ipfs-inactive/interface-js-ipfs-core#394
TODO:
* [x] Refactor local tests
* [x] Remove `addFromFs` and `addFromUrl` and export `globSource` and `urlSource` instead
* [x] Refactor `interface-ipfs-core` tests
* [x] Document new APIs in `interface-ipfs-core`
* [x] Update README with API changes
* [x] [Document upgrade path from Node.js/pull streams to async iterables](https://gist.github.com/alanshaw/04b2ddc35a6fff25c040c011ac6acf26)
Depends on:
* [x] ipfs/js-ipfs-utils#15
* [x] ipfs-inactive/interface-js-ipfs-core#567
BREAKING CHANGE: Callbacks are no longer supported on any API methods. Please use a utility such as [`callbackify`](https://www.npmjs.com/package/callbackify) on API methods that return Promises to emulate previous behaviour.
BREAKING CHANGE: `PeerId` and `PeerInfo` classes are no longer statically exported from `ipfs-http-client` since they are no longer used internally.
BREAKING CHANGE: `pin.add` results now contain a `cid` property (a [CID instance](https://github.com/multiformats/js-cid)) instead of a string `hash` property.
BREAKING CHANGE: `pin.ls` now returns an async iterable.
BREAKING CHANGE: `pin.ls` results now contain a `cid` property (a [CID instance](https://github.com/multiformats/js-cid)) instead of a string `hash` property.
BREAKING CHANGE: `pin.rm` results now contain a `cid` property (a [CID instance](https://github.com/multiformats/js-cid)) instead of a string `hash` property.
BREAKING CHANGE: `add` now returns an async iterable.
BREAKING CHANGE: `add` results now contain a `cid` property (a [CID instance](https://github.com/multiformats/js-cid)) instead of a string `hash` property.
BREAKING CHANGE: `addReadableStream`, `addPullStream` have been removed.
BREAKING CHANGE: `ls` now returns an async iterable.
BREAKING CHANGE: `ls` results now contain a `cid` property (whose value is a [CID instance](https://github.com/multiformats/js-cid)) instead of a `hash` property.
BREAKING CHANGE: `files.ls` now returns an async iterable.
BREAKING CHANGE: `files.readPullStream` and `files.readReadableStream` have been removed.
BREAKING CHANGE: `files.read` now returns an async iterable.
BREAKING CHANGE: `files.lsPullStream` and `files.lsReadableStream` have been removed.
BREAKING CHANGE: `files.ls` now returns an async iterable.
BREAKING CHANGE: `files.ls` results now contain a `cid` property (whose value is a [CID instance](https://github.com/multiformats/js-cid)) instead of a `hash` property.
BREAKING CHANGE: `files.ls` no longer takes a `long` option (in core) - you will receive all data by default.
BREAKING CHANGE: `files.stat` result now contains a `cid` property (whose value is a [CID instance](https://github.com/multiformats/js-cid)) instead of a `hash` property.
BREAKING CHANGE: `get` now returns an async iterable. The `content` property value for objects yielded from the iterator is now an async iterable that yields [`BufferList`](https://github.com/rvagg/bl) objects.
BREAKING CHANGE: `stats.bw` now returns an async iterable.
BREAKING CHANGE: `addFromStream` has been removed. Use `add` instead.
BREAKING CHANGE: `isIPFS` is no longer exported from the client, please `npm i is-ipfs` or include the CDN script tag `<script src="https://unpkg.com/is-ipfs/dist/index.min.js"></script>` to use this utility in your applications.
BREAKING CHANGE: `addFromFs` has been removed. Please use the exported `globSource` utility and pass the result to `add`. See the [glob source documentation](https://github.com/ipfs/js-ipfs-http-client#glob-source) for more details and an example.
BREAKING CHANGE: `addFromURL` has been removed. Please use the exported `urlSource` utility and pass the result to `add`. See the [URL source documentation](https://github.com/ipfs/js-ipfs-http-client#url-source) for more details and an example.
BREAKING CHANGE: `name.resolve` now returns an async iterable. It yields increasingly more accurate resolved values as they are discovered until the best value is selected from the quorum of 16. The "best" resolved value is the last item yielded from the iterator. If you are interested only in this best value you could use `it-last` to extract it like so:
```js
const last = require('it-last')
await last(ipfs.name.resolve('/ipns/QmHash'))
```
BREAKING CHANGE: `block.rm` now returns an async iterable.
BREAKING CHANGE: `block.rm` now yields objects of `{ cid: CID, error: Error }`.
BREAKING CHANGE: `dht.findProvs`, `dht.provide`, `dht.put` and `dht.query` now all return an async iterable.
BREAKING CHANGE: `dht.findPeer`, `dht.findProvs`, `dht.provide`, `dht.put` and `dht.query` now yield/return an object `{ id: CID, addrs: Multiaddr[] }` instead of a `PeerInfo` instance(s).
BREAKING CHANGE: `refs` and `refs.local` now return an async iterable.
BREAKING CHANGE: `object.data` now returns an async iterable that yields `Buffer` objects.
BREAKING CHANGE: `ping` now returns an async iterable.
BREAKING CHANGE: `repo.gc` now returns an async iterable.
BREAKING CHANGE: `swarm.peers` now returns an array of objects with a `peer` property that is a `CID`, instead of a `PeerId` instance.
BREAKING CHANGE: `swarm.addrs` now returns an array of objects `{ id: CID, addrs: Multiaddr[] }` instead of `PeerInfo` instances.
BREAKING CHANGE: `block.stat` result now contains a `cid` property (whose value is a [CID instance](https://github.com/multiformats/js-cid)) instead of a `key` property.
BREAKING CHANGE: `bitswap.wantlist` now returns an array of [CID](https://github.com/multiformats/js-cid) instances.
BREAKING CHANGE: `bitswap.stat` result has changed - `wantlist` and `peers` values are now an array of [CID](https://github.com/multiformats/js-cid) instances.
|
js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide. At the moment Please open an issue against |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Ad far as I can see, there is no option --stream (see ipfs/ipfs-companion#643 ) for IPNS name resolution.
Are there any plans to add a support for it?
The text was updated successfully, but these errors were encountered: