Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

HTTP client: CORS setup is two links deep from README #3597

Closed
alanshaw opened this issue Mar 21, 2021 · 1 comment · Fixed by #3943
Closed

HTTP client: CORS setup is two links deep from README #3597

alanshaw opened this issue Mar 21, 2021 · 1 comment · Fixed by #3943
Assignees
@hacdias
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now topic/docs Documentation

Comments

@alanshaw
Copy link
Member

One of the first things you need to do to use the HTTP client is to setup your IPFS node with CORS. At the moment I have to click into "Read the docs" and then "How to configure CORS for use with the http client" to access this information.

IMHO this is very important information that should not be hidden deep within the documentation, it should be one of the first things I read in the "Getting Started" section.
@alanshaw alanshaw added the need/triage Needs initial labeling and prioritization label Mar 21, 2021
@lidel lidel added topic/docs Documentation and removed need/triage Needs initial labeling and prioritization labels Apr 26, 2021
@lidel lidel added effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now labels May 17, 2021
@yusefnapora
Copy link
Contributor

@alanshaw, is this the info you want surfaced on the main README?

Does this also belong in the README for packages/ipfs-http-client (and maybe packages/ipfs-client)?

@hacdias hacdias self-assigned this Nov 19, 2021
@hacdias hacdias mentioned this issue Nov 19, 2021
Merged
achingbrain pushed a commit that referenced this issue Dec 2, 2021
@hacdias
docs: add CORS to getting started (#3943)
c272bfb 
Fixes #3597
@tinytb tinytb moved this to Done in IP JS (PL EngRes) v2 Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hacdias hacdias

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now topic/docs Documentation
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add CORS to getting started ipfs/js-ipfs
4 participants
@alanshaw @lidel @yusefnapora @hacdias