Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs #3601

Closed
jordan-public opened this issue Mar 30, 2021 · 2 comments · Fixed by #4251
Closed

ipfs #3601

jordan-public opened this issue Mar 30, 2021 · 2 comments · Fixed by #4251
Labels
need/analysis Needs further analysis before proceeding

Comments

@jordan-public
Copy link

  • Version:
    0.54.4

  • Platform:
    Darwin internal2.bitola.com 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64

  • Subsystem:
    js-ipfs: ipfs.files.write

Severity:

High - The main functionality of the application does not work, API breakage, repo format breakage, etc.

Description:

File upload / write truncates to 262144 when file is larger.

Steps to reproduce the error:

Use sample "browser-mfs" from "examples". Run it.
Drop any file larger than 262144 in the browser window. I used a 863KB file to upload.
The uploaded file is truncated to 262144.
@jordan-public jordan-public added the need/triage Needs initial labeling and prioritization label Mar 30, 2021
@achingbrain
Copy link
Member

May be a duplicate of #3576

@achingbrain achingbrain added need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization labels Apr 1, 2021
@scenaristeur
Copy link

any news on this issue ?

achingbrain added a commit that referenced this issue Nov 17, 2022
@achingbrain
fix: mfs blob import for files larger than 262144b
94c3722 
Turn the `Blob`/`File` object into a `ReadableStream` then turn that
into an `AsyncIterator<Uint8Array>` the same as the other input types.

Fixes #3601
Fixes #3576
@achingbrain achingbrain mentioned this issue Nov 17, 2022
Merged
achingbrain added a commit that referenced this issue Nov 17, 2022
@achingbrain
fix: mfs blob import for files larger than 262144b (#4251)
6be5906 
Turn the `Blob`/`File` object into a `ReadableStream` then turn that into an `AsyncIterator<Uint8Array>` the same as the other input types.

Fixes #3601
Fixes #3576
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
need/analysis Needs further analysis before proceeding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mfs blob import for files larger than 262144b ipfs/js-ipfs
3 participants
@achingbrain @scenaristeur @jordan-public