[Types] IPFS.create() options uses Libp2pConfig instead of Libp2pOptions

[rvagg]

Ref: ceramicnetwork/js-ceramic#1194 (comment)

js-ipfs/packages/ipfs-core/src/types.d.ts

Line 8 in 63b11e5

import type { Libp2pConfig as Libp2pOptions } from 'libp2p'

Sooo .. it looks like what's going on here is that ipfs-core is pulling in Libp2pConfig when it should be pulling in Libp2pOptions because Libp2pConfig is used for the config property inside Libp2pOptions. So in ceramicnetwork/js-ceramic#1194 I was having to pull up the elements in the libp2p.config object into libp2p to satisfy this condition. I think this should just be:

import type { Libp2pOptions } from 'libp2p'

[vasco-santos]

This should be the same as https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core/src/components/libp2p.js#L16 .

[achingbrain]

Ah, annoying - @vasco-santos that type doesn't actually look like it's used anywhere in the file. I wish our linter would pick that up.

[vasco-santos]

https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core/src/components/libp2p.js#L70 this function should return it, right?

[achingbrain]

We'd need to add a /** @type {Options} */ to https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core/src/components/libp2p.js#L164 otherwise it'll infer the return type instead of using the one defined in the @typedef.

That'd be fine initially but if we removed a property or something it'd just update the inferred return type rather than erroring on the change.