Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs get with single raw unixfs block writes empty dir #3682

Closed
olizilla opened this issue May 10, 2021 · 0 comments · Fixed by #3683
Closed

ipfs get with single raw unixfs block writes empty dir #3682

olizilla opened this issue May 10, 2021 · 0 comments · Fixed by #3683
Assignees
@olizilla
Labels
need/triage Needs initial labeling and prioritization

Comments

@olizilla
Copy link
Member 

$ echo "hello world" |  ipfs add --cid-version 1 -q
bafkreifjjcie6lypi6ny7amxnfftagclbuxndqonfipmb64f2km2devei4

$ ipfs get bafkreifjjcie6lypi6ny7amxnfftagclbuxndqonfipmb64f2km2devei4

$ ls -la bafkreifjjcie6lypi6ny7amxnfftagclbuxndqonfipmb64f2km2devei4                                                                                                 
total 0
@olizilla olizilla added the need/triage Needs initial labeling and prioritization label May 10, 2021
@olizilla olizilla self-assigned this May 10, 2021
olizilla added a commit that referenced this issue May 10, 2021
@olizilla
fix: ipfs get with raw blocks
befb8e6 
- tweak ipfs-cli get to handle `raw`
- tweak ipfs-core mapFile to handle `raw`

fixes #3682

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla mentioned this issue May 10, 2021
Merged
achingbrain pushed a commit that referenced this issue May 11, 2021
@olizilla
fix: ipfs get with raw blocks (#3683)
28235b0 
- tweak ipfs-cli get to handle `raw`
- tweak ipfs-core mapFile to handle `raw`
- mapFile doesn't handle all mapping object or identity types to an IPFSEntry, so throw if it finds one. This makes the cli behaviour match go-ipfs for ipfs get <cbor cid>
- add interface-core test for get with rawLeaves: true
- remove cli test for "raw" as core normalises the type to "file" so it was not testing a valid conditon

fixes #3682

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@olizilla olizilla

Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ipfs get with raw blocks ipfs/js-ipfs
1 participant
@olizilla