This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: is online is only online if libp2p is online #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #874 |
pgte
changed the title
pgte
changed the title
daviddias
reviewed
Jun 30, 2017
src/core/components/libp2p.js
Outdated
| if (self.isOnline()) { | ||
| dial() | ||
| } else { | ||
| self._libp2pNode.once('online', dial) |
There was a problem hiding this comment.
Oops, I knew I had another PR to submit...
See libp2p/js-libp2p#93
|
Depends on PRs:
|
daviddias
approved these changes
Jul 7, 2017
dryajov
pushed a commit
that referenced
this pull request
Sep 1, 2017
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, when peer is discovered but not online yet (racing cond), delay dial until libp2p is online.