node emits "online" event once online #93
Conversation
src/index.js
Outdated
| @@ -187,6 +187,8 @@ class Node extends EventEmitter { | |||
| return each(this.modules.discovery, (d, cb) => d.start(cb), cb) | |||
| } | |||
| cb() | |||
|
|
|||
| this.emit('online') | |||
There was a problem hiding this comment.
I'm not convinced that online/offline is the right wording here. In js-ipfs we have:
start/stop sounds better because online has a lot of assumptions today. To me, start/stop say "hey, the thing you set up, is running".
Thoughts?
There was a problem hiding this comment.
Agree, "online" is somewhat ambiguous, and not the goal. I'd say started and stopped are what are the really important events for the user (at the libp2p and ifs levels).
Following that trail, I think this leads to replacing .isOnline() with .isStarted(), no?
There was a problem hiding this comment.
@pgte I like that :) (maybe isRunning?)
There was a problem hiding this comment.
Perhaps we should use the same verbs, otherwise it may get confusing to users, no?
The other alternative is to be explicit (in the docs) about the state machine (states) and the transitions (events). Example:
starting event -> starting state -> started event -> running state -> stopping event -> stopped state
Makes sense?
* feat: convergence * structure examples
|
As discussed, switched to "start" and "stop" events. Also, replaced |
|
Rebased PR after opening, now GH is all confused about the diff. Closing this one to create a new PR.. |
Bumps [it-length-prefixed](https://github.com/alanshaw/it-length-prefixed) from 2.0.0 to 3.0.0. - [Release notes](https://github.com/alanshaw/it-length-prefixed/releases) - [Changelog](https://github.com/alanshaw/it-length-prefixed/blob/master/CHANGELOG.md) - [Commits](alanshaw/it-length-prefixed@v2.0.0...v3.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
To support ipfs/js-ipfs#891