This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement "file ls" #1078
Merged
Implement "file ls" #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@richardschneider I had understood from IRC that you opted by the direction of not using file ls anymore, did that change? |
It turns out there is just not enough information about the directory. Also, asking for file information is not supported (I think)
|
I've raised #1079, about the subfolder issue. However, to summarise why I can't use
So instead of breaking interfaces, I just implemented an existing interface. PS: This got mounting IPFS on windows with js-ipfs working 🕺 |
@diasdavid LGTM |
ipfs.ls does not provide enough information
ghost
assigned daviddias
Nov 17, 2017
daviddias
approved these changes
Nov 17, 2017
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
Adds a method called `ipfs._addAsyncIterator`, prefixed with an underscore to mark it as sort of unofficial (though it's what `ipfs.add` will become once the async iterator migration is complete) and we don't want to implement symmetrical `ipfs.catAsyncIterator` etc methods, or at least not yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
file ls
to both the CLI and HTTP API. CLI docs and API docs.