-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: disable WebRTC by default and add how to support it + websocket-star to the FAQ #1111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
- Coverage 83.49% 83.48% -0.02%
==========================================
Files 121 121
Lines 2726 2724 -2
==========================================
- Hits 2276 2274 -2
Misses 450 450
Continue to review full report at Codecov.
|
@@ -344,7 +369,7 @@ const node = new IPFS({ | |||
Swarm: [ | |||
"/ip4/0.0.0.0/tcp/4002", | |||
"/ip4/127.0.0.1/tcp/4003/ws", | |||
"/dns4/star-signal.cloud.ipfs.team/wss/p2p-webrtc-star" | |||
"/dns4/wrtc-star.discovery.libp2p.io/wss/p2p-webrtc-star" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on libp2p/js-libp2p-webrtc-star#126
config: { | ||
Addresses: { | ||
Swarm: [ | ||
'/dns4/ws-star.discovery.libp2p.io/wss/p2p-websocket-star' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on libp2p/js-libp2p-websocket-star-rendezvous#9
16ec3ea
to
979af0e
Compare
README.md
Outdated
@@ -398,6 +417,33 @@ const node = new IPFS({ | |||
|
|||
The code above assumes you are running a local `signaling server` on port `9090`. Provide the correct values accordingly. | |||
|
|||
#### Is there a more stable alternative to websocket-star that offers a similar functionality? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you mean webrtc-star
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thank you :)
Validated that websocket-star is indeed working with the newly deployed rendezvous point by @victorbjelkholm, great job! |
ad360b9
to
cfdf1a2
Compare
No description provided.