Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: disable WebRTC by default and add how to support it + websocket-star to the FAQ #1111

Merged
merged 5 commits into from
Nov 27, 2017

Conversation

daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Nov 26, 2017
@ghost ghost added the status/in-progress In progress label Nov 26, 2017
@daviddias daviddias mentioned this pull request Nov 26, 2017
24 tasks
@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #1111 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   83.49%   83.48%   -0.02%     
==========================================
  Files         121      121              
  Lines        2726     2724       -2     
==========================================
- Hits         2276     2274       -2     
  Misses        450      450
Impacted Files Coverage Δ
src/core/runtime/libp2p-nodejs.js 91.66% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940e27...5513460. Read the comment docs.

@@ -344,7 +369,7 @@ const node = new IPFS({
Swarm: [
"/ip4/0.0.0.0/tcp/4002",
"/ip4/127.0.0.1/tcp/4003/ws",
"/dns4/star-signal.cloud.ipfs.team/wss/p2p-webrtc-star"
"/dns4/wrtc-star.discovery.libp2p.io/wss/p2p-webrtc-star"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config: {
Addresses: {
Swarm: [
'/dns4/ws-star.discovery.libp2p.io/wss/p2p-websocket-star'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daviddias daviddias changed the title fix: disable WebRTC by default fix: disable WebRTC by default and add how to support it + websocket-star to the FAQ Nov 27, 2017
README.md Outdated
@@ -398,6 +417,33 @@ const node = new IPFS({

The code above assumes you are running a local `signaling server` on port `9090`. Provide the correct values accordingly.

#### Is there a more stable alternative to websocket-star that offers a similar functionality?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you mean webrtc-star?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you :)

@daviddias
Copy link
Member Author

image

Validated that websocket-star is indeed working with the newly deployed rendezvous point by @victorbjelkholm, great job!

@daviddias daviddias merged commit 795e1ec into master Nov 27, 2017
@daviddias daviddias deleted the disable-webrtc-by-default branch November 27, 2017 11:12
@ghost ghost removed the status/in-progress In progress label Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants