This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: /api/v0/dns #1172
Merged
feat: /api/v0/dns #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
|
2 tasks
|
@diasdavid some tests will fail since it doesn't use the js-ipfs-api from ipfs-inactive/js-ipfs-http-client#665 |
|
And this one too is done @diasdavid 🚀 |
|
Ping @diasdavid |
daviddias
suggested changes
Jan 12, 2018
test/cli/dns.js
Outdated
| this.timeout(60 * 1000) | ||
|
|
||
| return ipfs('dns ipfs.io').then((res) => { | ||
| console.log(res) |
|
Fixed @diasdavid! Was using |
|
Is there anything missing here @diasdavid? |
daviddias
approved these changes
Jan 16, 2018
This was referenced Jul 6, 2023
This was referenced Jul 6, 2023
This was referenced Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: #904, ipfs-inactive/js-ipfs-http-client#665
On Node.js we use
dns.resolveTxtto get thednslinkpath. On the browser, we use the public gateway.