This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: Display error when using unkown cli option #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
approved these changes
Apr 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the yargs strict was disabled, in order to remove some strange problems regarding fail callbacks, which were inadvertently called. After digging through the yargs validation code, I ended up finding the problem.
The yargs positional arguments validation for positional arguments does not support positional arguments in kebab-case notation (yargs Issue). Therefore, I changed to camelCase those. With this modification and enabling strict generally in the CLI.
And now we have errors for unknown options! 💪😎
Closes 563