Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

example(run-in-electron): update to latest electron 2.0, electron-rebuild 1.7.2 #1351

Merged
merged 1 commit into from
May 23, 2018
Merged

example(run-in-electron): update to latest electron 2.0, electron-rebuild 1.7.2 #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ If your [electron-rebuild step is failing](https://github.com/ipfs/js-ipfs/issue

```bash
# Electron's version.
export npm_config_target=1.7.6
export npm_config_target=2.0.0
# The architecture of Electron, can be ia32 or x64.
export npm_config_arch=x64
export npm_config_target_arch=x64
Expand Down
2 changes: 0 additions & 2 deletions examples/run-in-electron/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

> This example is heavily inspired by [electron-quick-start](https://github.com/electron/electron-quick-start).

**DISCLAIMER:** This example is still a work in progress, it currently doesn't work due to the usage of native dependencies that Electron is not supporting.
Copy link
Member

@daviddias daviddias May 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting that it now works on Electron Main Process as well!

ipfs/notes#256


To try it by yourself, do:

```
Expand Down
2 changes: 1 addition & 1 deletion examples/run-in-electron/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Electron's version.
export npm_config_target=1.6.11
export npm_config_target=2.0.0
# The architecture of Electron, can be ia32 or x64.
export npm_config_arch=x64
export npm_config_target_arch=x64
Expand Down
4 changes: 2 additions & 2 deletions examples/run-in-electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"author": "David Dias <daviddias@ipfs.io>",
"license": "MIT",
"devDependencies": {
"electron": "~1.6.11",
"electron-rebuild": "^1.5.11",
"electron": "^2.0.0",
"electron-rebuild": "^1.7.2",
"ipfs": "ipfs/js-ipfs"
}
}