Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: modular interface tests #1389

Merged
merged 19 commits into from
Jul 2, 2018
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jun 8, 2018

This PR updates js-ipfs to use the new interface-ipfs-core tests. This gives us fine grained control over what tests we run.

Please see the description on the PR for more information on the reasons behind this change.

This also enables a bunch of tests that weren't previously being run 🎉 ...and removes a LOT of duplicated code for running the interface tests.

requires ipfs-inactive/interface-js-ipfs-core#290

@alanshaw
Copy link
Member Author

alanshaw commented Jul 2, 2018

I've rebased this against the new-libp2p branch and tested against ipfs-inactive/interface-js-ipfs-core#319 and the tests are passing: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs/detail/feat%2Fmodular-interface-tests-rebase-new-libp2p/2/pipeline/18

Hopefully we can get new-libp2p merged and this'll go in straight after.

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
Reduces code repetition, allows test skipping and running only some tests.

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw alanshaw force-pushed the feat/modular-interface-tests branch from 402b865 to a2a018f Compare July 2, 2018 13:48
@alanshaw
Copy link
Member Author

alanshaw commented Jul 2, 2018

@diasdavid CI green \o/ - ok to merge?

@daviddias daviddias merged commit 18888be into master Jul 2, 2018
@ghost ghost removed the status/in-progress In progress label Jul 2, 2018
@daviddias daviddias deleted the feat/modular-interface-tests branch July 2, 2018 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants