This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: update mfs dep to make interop tests pass #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
reviewed
Jul 13, 2018
package.json
Outdated
| @@ -108,7 +108,7 @@ | |||
| "ipfs-block": "~0.7.1", | |||
| "ipfs-block-service": "~0.14.0", | |||
| "ipfs-http-response": "~0.1.2", | |||
| "ipfs-mfs": "~0.0.16", | |||
| "ipfs-mfs": "~0.0.17", | |||
There was a problem hiding this comment.
Please release a minor version. Seems that the error message changed and that should be considered a breaking change.
There was a problem hiding this comment.
Hmm, I should have done that ages ago:
How should I deal with revisions in the 0.y.z initial development phase?
The simplest thing to do is start your initial development release at 0.1.0 and then increment the minor version for each subsequent release.
daviddias
suggested changes
Jul 13, 2018
achingbrain
force-pushed
the
update-mfs-dep
branch
from
c41ff80
to
d27bf0c
Compare
daviddias
approved these changes
Jul 13, 2018
alanshaw
approved these changes
Jul 14, 2018
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 15, 2024
This was referenced Feb 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version updates the error messages to be the same as go, and fixes the case where
mkdiring an existing directory with the-poption should not cause an error to occur.