This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: support --raw-leaves and --cid-base #1454
Merged
Merged
+35
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned achingbrain
Jul 19, 2018
achingbrain
force-pushed
the
support-raw-leaves
branch
from
July 19, 2018 15:17
ea3f002
to
91abc7e
Compare
This was referenced Jul 19, 2018
achingbrain
added a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 19, 2018
Documents the new options added by ipfs/js-ipfs#1454 as well as the missing `long` option from `files.ls`
Documented in ipfs-inactive/interface-js-ipfs-core#334 |
achingbrain
added a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 19, 2018
Documents the new options added by ipfs/js-ipfs#1454 as well as the missing `long` option from `files.ls`
achingbrain
force-pushed
the
support-raw-leaves
branch
from
July 20, 2018 13:55
91abc7e
to
e29e665
Compare
achingbrain
force-pushed
the
support-raw-leaves
branch
from
July 20, 2018 15:16
e29e665
to
d4bccce
Compare
@achingbrain I think these out of date tests are causing the failures: Lines 208 to 258 in f4344b0
|
achingbrain
force-pushed
the
support-raw-leaves
branch
from
July 23, 2018 12:50
d4bccce
to
7b92684
Compare
CI is full of yarn/npm fail:
But you are right those tests should fail. For me locally they pass because an error is returned while executing the command, but the error is not the one expected and the tests don't assert anything past 'there should be an error' so they pass where they should fail. I've updated them to expect success and not failure conditions. |
achingbrain
force-pushed
the
support-raw-leaves
branch
3 times, most recently
from
July 24, 2018 12:05
a7d3d37
to
cb9982d
Compare
Also updates pinning to support CIDv1
achingbrain
force-pushed
the
support-raw-leaves
branch
from
July 24, 2018 13:17
cb9982d
to
186b80a
Compare
seeing green CI, can we get this merged and we'll improve coverage after the summit? |
alanshaw
approved these changes
Jul 25, 2018
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 28, 2018
Documents the new options added by ipfs/js-ipfs#1454 as well as the missing `long` option from `files.ls`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest version of
js-ipfs-mfs
to properly support the--raw-leaves
argument and allow formatting CIDs in base32 when doingls
andstat
mfs operations.