This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: update ipfs-unixfs-engine dependency #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned 
|
ha, tests are failing because they're wrong - they're expecting the CID of the empty file zdj7WiLc855B1KPRgV7Fh8ivjuAhePE1tuJafmxH5HmmSjqaD 🤣 😭 |
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
7 tasks
lidel
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
LGTM!
I re-tested ipfs/js-ipfs-http-response#9 with js-ipfs from this branch (@ eb1b3b3) and AFAIK the issue is fixed, CIDv1 tests pass, CID of actual file is returned as expected 👌
|
Thanks @lidel - the issue now appears to be interop with go-ipfs when the file is < max chunk size - you get a different CID to go-ipfs. |
alanshaw
changed the title
The raw leaves option should not be defaulted to false as its value is set to true by unixfs-engine if CID version is set and the user has not specified a value for raw leaves. Also adds tests cases for CID version option with different file sizes. License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
This was referenced Aug 22, 2018
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1518
@lidel do you have time to verify this fix?