Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

docs: add parceljs browser example #1726

Merged
merged 5 commits into from
Nov 30, 2018
Merged

Conversation

raoulmillais
Copy link
Contributor

@raoulmillais raoulmillais commented Nov 21, 2018

This is an example of developing and building a Dapp which connects to IPFS that is bundled by Parcel.js: one of the desired examples in #1436

A version served over IPFS can be found here (for the commit that opens this PR)

Notes and known limitations

Please be gentle this is my first non-typo IPFS contribution, I look forward to any feedback. :)

@raoulmillais
Copy link
Contributor Author

I'm getting a bit lost trying to investigate the build failures. The OSX tests are failing for a timeout. Master seems to be built using CIrcleCI and the PR by jenkins, both seem to have been failing for a while now (going by red crosses next to all first page of commits on master and all first page of open pull requests). Should I be concerned about this? If so, could someone give me a pointer please?

@raoulmillais
Copy link
Contributor Author

raoulmillais commented Nov 26, 2018

While playing around with IPFS using Parcel.js I came across a problem with babel-preset-env transpiling too aggressively and breaking for...of loops. See this issue for more details. Reconfiguring browserslist to only support latest 2 chrome versions prevents hitting this problem.

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ❤️ thank you! The code LGTM, just a couple of minor tweaks and this should be good to merge!

examples/browser-parceljs/README.md Show resolved Hide resolved
examples/browser-parceljs/package.json Outdated Show resolved Hide resolved
@raoulmillais
Copy link
Contributor Author

I've made the requested changes. I haven't rebased the pull request off master and this PR is now behind, should I rebase @alanshaw?

@raoulmillais
Copy link
Contributor Author

The commitlint check is failing because I accidentally missed the 's' off docs on this commit I'll have to rebase to fix this unless you plan to squash the commits when merging. Sorry, I'm still getting to grips of the protocol you follow so I've been cautious and left it as-is.

@raoulmillais
Copy link
Contributor Author

raoulmillais commented Nov 29, 2018

The force push is changing the README image to match the code on the tip of this PR

@raoulmillais
Copy link
Contributor Author

Fastly is caching the README image, it will be in sync with the code when the cache expires

@alanshaw
Copy link
Member

Changes look great. I'll give it a spin tomorrow morning and if it all works we can merge - thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants