This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: race condition causing Database is not open error #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@achingbrain this is basically the change you did here for js-ipfs-mfs |
Merged
achingbrain
approved these changes
Jan 21, 2019
[`cleanup`](https://github.com/ipfs/js-ipfs/blob/7d9b006d0b0542651cbaa540d5f22a0112ae09bd/src/cli/bin.js#L109) closes the DB but `yargs-promise` does not wait for async stuff in the command handler to finish, and executes that promise chain immediately after the handler is executed. So it's a race condition. In windows, _sometimes_, the database is closed before the async stuff from the handler completes. This PR changes the CLI command handlers to always pass a promise to `resolve` function that `yargs-promise` adds to the context (`argv`). This makes `yargs-promise` wait for it to be resolved before continuing the promise chain and closing the DB. Since I had to edit all of the commands to make them use the `resolve` function and introduce promises, I decided to take the opportunity to refactor the CLI commands to use async/await. It should help towards #1670. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
fix/db-is-not-open
branch
from
e232d93
to
f34df6f
Compare
|
I will update the DHT CLI for ipfs/js-ipfs#856 according to the changes here! |
This was referenced Jan 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanupcloses the DB butyargs-promisedoes not wait for async stuff in the command handler to finish, and executes that promise chain immediately after the handler is executed. So it's a race condition. In windows, sometimes, the database is closed before the async stuff from the handler completes.This PR changes the CLI command handlers to always pass a promise to
resolvefunction thatyargs-promiseadds to the context (argv). This makesyargs-promisewait for it to be resolved before continuing the promise chain and closing the DB.Since I had to edit all of the commands to make them use the
resolvefunction and introduce promises, I decided to take the opportunity to refactor the CLI commands to use async/await. It should help towards #1670.Also, w00t! - removed almost 200 LOC