Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: swallowed errors #1860

Merged
merged 4 commits into from
Feb 6, 2019
Merged

fix: swallowed errors #1860

merged 4 commits into from
Feb 6, 2019

Commits on Feb 5, 2019

  1. fix: swallowed errors 

    The switch to using `yargs-promise` for `ipfs init` and `ipfs daemon` commands caused an unhandled promise rejection and in some cases would cause an error to not be printed to the console.

This PR greatly simplifies the code in `src/cli/bin.js`, to always use `yargs-promise`. Command handlers are now passed an async `getIpfs` function instead of an `ipfs` instance. It means that we don't have to differentiate between commands that use an IPFS instance in `src/cli/bin.js`, giving the handler the power to call `getIpfs` or not to obtain an IPFS instance as and when needed. This removes a whole bunch of complexity from `src/cli/bin.js` at the cost of adding a single line to every command handler that needs to use an IPFS instance.

This enables operations like `echo "hello" | jsipfs add -q | jsipfs cid base32` to work without `jsipfs cid base32` failing because it's trying to acquire a repo lock when it doesn't use IPFS at all.

fixes #1835
refs #1858
refs libp2p/js-libp2p#311

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
    @alanshaw
    alanshaw committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    120f072 View commit details
    Browse the repository at this point in the history

  2. fix: parse args before command handlers are added 

    License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
    @alanshaw
    alanshaw committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    6a8d43a View commit details
    Browse the repository at this point in the history

  3. fix: help 

    License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
    @alanshaw
    alanshaw committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    76a6930 View commit details
    Browse the repository at this point in the history

  4. refactor: clean up 

    License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
    @alanshaw
    alanshaw committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    540a77d View commit details
    Browse the repository at this point in the history