This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: use pull-mplex #1884
Merged
feat: use pull-mplex #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacobheun
commented
Feb 18, 2019
•
jacobheun
commented
- run ipfs/interop tests against this change
ghost
assigned 
jacobheun
force-pushed
the
feat/pull-mplex
branch
from
d577d19
to
9df6fb0
Compare
|
@jacobheun any chance i can help out with this ? this PR fixes vue support and protoschool |
jacobheun
force-pushed
the
feat/pull-mplex
branch
from
f8c44e2
to
f8222d8
Compare
|
@hugomrdias i just rebased this with master so it has the latest updates. I have a WIP pr over at ipfs/interop#59 that I haven't been able to spend a ton of time on. I think this is in a good spot, but the interop tests have been unreliable as of late. It would be nice to get more deterministic results there. |
jacobheun
force-pushed
the
feat/pull-mplex
branch
from
f8222d8
to
9b7e038
Compare
jacobheun
force-pushed
the
feat/pull-mplex
branch
from
9b7e038
to
700c296
Compare
|
@jacobheun can we ship this? 🚢 😁 🙏 |
|
@alanshaw not yet, ipfs/interop has an issue with pubsub I did not have a chance to look at last week. I will look into it more today/tomorrow. |
jacobheun
force-pushed
the
feat/pull-mplex
branch
from
700c296
to
fc5bfac
Compare
test: shut off dht by default
|
The underlying issue with pubsub interop has been fixed, this is ready to go. You can see the passing interop tests at ipfs/interop#67. |
hugomrdias
approved these changes
May 6, 2019
alanshaw
approved these changes
May 8, 2019
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.