This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
files add, cat, get core + cli #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (inPath === '.' && recursive === true) { | ||
| inPath = process.cwd() | ||
| return inPath |
There was a problem hiding this comment.
Is there a need for this return?
There was a problem hiding this comment.
inPath is not declared in this scope and needs to be returned on line 58, unless I'm missing something.
There was a problem hiding this comment.
I mean, since there is the return of inPath in the end of the func and this assignment of inPath is within a if/else clause, you just need the return once
| filePair = {path: addPath, stream: rs} | ||
| i.write(filePair) | ||
| callback() | ||
| } |
There was a problem hiding this comment.
This could be simplified:
if (!fs.statSync(element).isDirectory()) {
i.write({path: addPath, stream: fs.createReadStrem(element})
}
callback()
|
@nginnever CR'ed :) |
Merged
|
Merged in #204 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.