This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: ipns using offline datastore if no dht #1988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Can we get the build green and add a test? |
vasco-santos
force-pushed
the
fix/ipns-using-offline-datastore-if-no-dht
branch
from
7eb8937
to
8617d65
Compare
alanshaw
approved these changes
Apr 12, 2019
|
@vasco-santos I've merged this into #1991 as I think they now depend on each other! |
|
@alanshaw just added a new commit to skip the ipns over dht tests. You should grab it as well, or skip in your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DHT is not enabled, we must add the
OfflineDatastoreto for IPNS instead of the DHT