Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: clean repo func on windows #2243

Merged
merged 1 commit into from
Jul 12, 2019
Merged

fix: clean repo func on windows #2243

merged 1 commit into from
Jul 12, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jul 12, 2019

rimraf.sync does not retry when it encounters errors on windows. The async version retries a number of times before failing.

See isaacs/rimraf#72 for context on why rimraf on windows might error.

Attempting to fix this error seeing quite often in CI now:

windows-error

`rimraf.sync` does not retry when it encounters errors on windows. The async version retries a number of times before failing.

See isaacs/rimraf#72 for context on why rimraf on windows might error.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw marked this pull request as ready for review July 12, 2019 11:59
@alanshaw
Copy link
Member Author

I re-ran the windows tests multiple times and did not see this error again.

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to save a lot of time 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants