This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: do not generate aegir docs on release #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not used and get put into the `docs` directory which is no longer ignored so we end up with a dirty repo on release. refs #2502 (comment) License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
achingbrain
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Perhaps aegir should generate docs to a temporary folder.
Saw a thing about Typescript definitions in another issue, they’d make for a good doc generation base, then we wouldn’t have to keep the API doc in the README in sync manually, we could just link to that.
|
+1 #2548 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not used and get put into the
docsdirectory which is no longer ignored so we end up with a dirty repo on release.refs #2502 (comment)