Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: replace websocket-star with stardust #2578

Closed
wants to merge 8 commits into from

Conversation

mkg20001
Copy link
Contributor

<humor>

feat: websocket-star? what's that. only heard of stardust!

(...psst, we're replacing ws-star with stardust, which does
the same things, except it's way faster & more secure)

</humor>

@mkg20001
Copy link
Contributor Author

I've replaced all occurrences of ws-star with stardust
I'd have to add the necessary code to enable stardust as well, after that it should be ready

@mkg20001 mkg20001 force-pushed the feat/ws-star2stardust branch from 9969981 to acc8a6a Compare October 31, 2019 12:25
@mkg20001
Copy link
Contributor Author

@mkg20001
Copy link
Contributor Author

Currently working on the custom bundle replacement

@mkg20001
Copy link
Contributor Author

Need a feature: #2579

@mkg20001
Copy link
Contributor Author

Also would need some feedback on my idea with the overrideFunction option

@mkg20001

This comment has been minimized.

@mkg20001
Copy link
Contributor Author

mkg20001 commented Nov 1, 2019

We could rename overrideFunction to hooks and make it an array, to allow adding multiple modules at once (stardust4ipfs + webrtc4ipfs for ex)

@mkg20001 mkg20001 force-pushed the feat/ws-star2stardust branch from 61e7e90 to 94a8055 Compare November 7, 2019 18:20
@alanshaw
Copy link
Member

alanshaw commented Nov 7, 2019

@mkg20001 can you please base this PR on #2591? It should allow you to add stardust easily without adding more configuration options and complexity.

@alanshaw
Copy link
Member

ping @mkg20001

@alanshaw
Copy link
Member

ping @mkg20001 - do you want me to pull this one over the line?

@mkg20001
Copy link
Contributor Author

Yes

@mkg20001
Copy link
Contributor Author

#2600

@mkg20001
Copy link
Contributor Author

@alanshaw Oh wait I understood "Do you want to pull this over the line?" 😅

@lidel
Copy link
Member

lidel commented Nov 28, 2019

@mkg20001 just to be sure I got this right:
this PR should be closed, and @alanshaw should review #2600, is that correct?

@mkg20001
Copy link
Contributor Author

Correct

@mkg20001 mkg20001 closed this Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants