This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: bootstrap rm return value when all option is set #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroMiguelSS
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Nov 22, 2019
The assertion was commented out temporarly due to bootstrap.rm bug that was fixed here ipfs/js-ipfs#2626
PedroMiguelSS
force-pushed
the
chore/interface-tests-async-node-creation
branch
from
768d28d
to
0671a5e
Compare
PedroMiguelSS
force-pushed
the
fix/bootstrap-rm-return-value
branch
2 times, most recently
from
98390c2
to
765d2a3
Compare
PedroMiguelSS
force-pushed
the
fix/bootstrap-rm-return-value
branch
from
765d2a3
to
ab5634d
Compare
alanshaw
approved these changes
Nov 26, 2019
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Nov 26, 2019
* chore: bitswap async/await refactor * chore: block async/await refactor * chore: bootstrap async/await refactor * chore: config async/await refactor * chore: dag async/await refactor * chore: dht async/await refactor * chore: files-mfs async/await refactor * chore: files-regular async/await refactor * chore: key async/await refactor * chore: miscellaneous async/await refactor * chore: name-pubsub async/await refactor * chore: name async/await refactor * chore: object async/await refactor * chore: pin async/await refactor * chore: ping async/await refactor * chore: pubsub async/await refactor * chore: repo async/await refactor * chore: stats async/await refactor * chore: swarm async/await refactor * chore: remove unnecessary util file * chore: update dependencies * refactor: remove async dep and unnecessary utils * refactor: bitswap before and after methods to async syntax * refactor: block before and after methods to async syntax * refactor: bootstrap before and after methods to async syntax * refactor: config before and after methods to async syntax * refactor: dag before and after methods to async syntax * refactor: dht before and after methods to async syntax * refactor: files-mfs before and after methods to async syntax * refactor: files-regular before and after methods to async syntax * refactor: key before and after methods to async syntax * refactor: miscellaneous before and after methods to async syntax * refactor: name before and after methods to async syntax * refactor: name-pubsub before and after methods to async syntax * refactor: object before and after methods to async syntax * refactor: pin before and after methods to async syntax * refactor: ping before and after methods to async syntax * refactor: pubsub before and after methods to async syntax * refactor: repo before and after methods to async syntax * refactor: stats before and after methods to async syntax * chore: remove 'only' from files-mfs/cp * chore: uncomment bootstrap rm test assertion The assertion was commented out temporarly due to bootstrap.rm bug that was fixed here ipfs/js-ipfs#2626 * refactor: name resolve test * fix: increase dht findProvs test timeout * fix: miscellaneous stop test
PedroMiguelSS
pushed a commit
that referenced
this pull request
Nov 28, 2019
achingbrain
pushed a commit
that referenced
this pull request
Dec 10, 2019
* chore: change interface tests to async node creation * fix: bootstrap rm return value when all option is set (#2626) * chore: update interface-ipfs-core dep * chore: code review changes * chore: link interface core tests dependency to new branch * chore: update interface-core dep * refactor: aegir pre and post hooks on both node and browser * chore: restore interface tests branch * chore: control peer id version * chore: use version of http client with controlled peer id version * fix: use regular version of http client * chore: update interface test version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the return value of
bootstrap.rm()whenalloption is set.i.e.:
ipfs.bootstrap.rm({ all: true })was returning{ Peers: [] }But it should return
{ Peers: [address1, address2, ...] }instead.