Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: pass timeout arg to server #2979

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Commits on Apr 14, 2020

  1. fix: pass timeout arg to server

    Refactors how we pass url params to the API, all args are now normalised
    in one place.  If a timeout is passed it is passed on to the server as
    a url search param.
    
    N.b. this does mean that timeouts are set in the client and on the server
    so it's not always clear which will expire first, though one will expire.
    
    We do our best to ensure the errors are the same, though when the API
    is streaming there's no way to tell if the request completed successfully
    or if the timeout occured as the timeout message arrives in http trailers.
    achingbrain committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    524722a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eee89b8 View commit details
    Browse the repository at this point in the history