This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: webui v2.7.5, with feeling #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switched to latest webui and ensures it is loaded from the same Origin as the RPC API. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
commented
Apr 14, 2020
| const log = debug('ipfs:webui:info') | ||
| log.error = debug('ipfs:webui:error') | ||
|
|
||
| const webuiCid = 'bafybeigxqbvc6qxk2wkdyzpkh7mr7zh5pxbvpjb6a6mxdtpwhlqaf4qj5a' // v2.7.4 |
There was a problem hiding this comment.
@jessicaschilling FYI in the future, when we release new ipfs-webui we will need to update only this one line 🤞
There was a problem hiding this comment.
@lidel Is this the new version of the (broken link) js-ipfs file that appears here? https://github.com/ipfs-shipyard/ipfs-webui#releasing-a-new-version-of-the-webui
There was a problem hiding this comment.
@jessicaschilling Yes. I'll update that README when we finish the release dance for v2.7.4
|
It would be really nice to get a smoke test for the webui - it could use nightwatch to spin up a node, open a browser and just assert on the revision in the UI. |
achingbrain
approved these changes
Apr 23, 2020
lidel
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit bigger than expected, but I am running on robusta so completed some side quests:
/webuiopened in browser returned HTTP 405 because browser sends GET and not a POST :-)/webuinow loads from API port and works with POST-only RPC API/webuiis loaded from the same Origin as the RPC API itself/api/v0on API port. When that happens, pages loaded from Gateway won't have access to the API port without being whitelisted, and we want /webui work out of the box without the need for any manual configuration./webuiand/webui/work nowcc #2971