This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: use eslint-config-ipfs #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
commented
Sep 15, 2020
2 tasks
Gozala
commented
Sep 15, 2020
Gozala
commented
Sep 15, 2020
Gozala
commented
Sep 15, 2020
Gozala
commented
Sep 15, 2020
Gozala
commented
Sep 15, 2020
Gozala
commented
Sep 15, 2020
|
@jacobheun you've offered to take some reviews off of @achingbrain's plate. If you have time to review this it would be great to get this inn. |
achingbrain
reviewed
Oct 6, 2020
achingbrain
approved these changes
Oct 6, 2020
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Uses shared eslint config `eslint-config-ipfs` by integrating ipfs/aegir#638. Shared config uses new jsdoc plugin enabling use to remove bunch of `eslint-disable-next-line valid-jsdoc` comments. On the flip side it adds bit more requirements for structuring jsdoc comments. Most changes are generated automatically by eslint with `--fix` flag. This change also intentionally adds `.eslintrc` files to every package with content `{ "extends": "ipfs" }`, so that all the tools that support eslint pick up desired configuration. `eslint-config-ipfs` package itself isn't added to dependencies, because it gets installed as `aegir` dependency. Co-authored-by: achingbrain <alex@achingbrain.net>
This was referenced Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates use shared eslint config
eslint-config-ipfsby integrating ipfs/aegir#638. Shared config uses new jsdoc plugin enabling use to remove bunch ofeslint-disable-next-line valid-jsdoccomments. On the flip side it adds bit more requirements for structuring jsdoc comments. Most changes are generated automatically by eslint with--fixflag.This change also intentionally adds
.eslintrcfiles to every package with content{ "extends": "ipfs" }, so that all the tools that support eslint pick up desired configuration.eslint-config-ipfspackage itself isn't added to dependencies, because it gets installed asaegirdependency.