This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Typecheck github action #3327
Merged
Typecheck github action #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
force-pushed
the
gozala/typecheck
branch
5 times, most recently
from
2c0adc0 to
099bd0f
Compare
Gozala
force-pushed
the
gozala/typecheck
branch
3 times, most recently
from
d9058b2 to
92713ae
Compare
Gozala
force-pushed
the
gozala/typecheck
branch
from
92713ae to
64bec9e
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a github action to #3281, which runs type check and reports any missmateches in the pull request diff view. Screenshots below are from #3328 which reverted two changes from #3281 back to how they were on master which pass all tests, but fail type checker:
Since this adds a separate action, it allows us to have more relaxed policies in regards to changes that fail checks. Also I hope that messages in the pull request may encourage contributors to resolve reported issues and sometimes (unfortunately not always) they are clear enough to require no TS knowledge at all.