make the config API spec compliant

package.json

@@ -67,8 +67,8 @@
     "fs-blob-store": "^5.2.1",
     "glob": "^7.0.5",
     "hapi": "^14.0.0",
+    "ipfs-api": "^7.0.0",
     "ipfs-bitswap": "^0.6.0",
-    "ipfs-api": "^6.0.3",
     "ipfs-block": "^0.3.0",
     "ipfs-block-service": "^0.4.0",
     "ipfs-merkle-dag": "^0.6.2",
@@ -80,11 +80,11 @@
     "joi": "^9.0.4",
     "libp2p-ipfs": "^0.12.1",
     "libp2p-ipfs-browser": "^0.12.1",
-    "lodash.get": "^4.4.0",
-    "lodash.set": "^4.3.0",
+    "lodash.get": "^4.4.1",
+    "lodash.set": "^4.3.1",
     "mafmt": "^2.1.1",
-    "multihashes": "^0.2.2",
     "multiaddr": "^2.0.2",
+    "multihashes": "^0.2.2",
     "path-exists": "^3.0.0",
     "peer-book": "^0.3.0",
     "peer-id": "^0.7.0",
@@ -117,4 +117,4 @@
     "kumavis <kumavis@users.noreply.github.com>",
     "nginnever <ginneversource@gmail.com>"
   ]
-}
+}

src/cli/commands/config.js

@@ -46,7 +46,7 @@ module.exports = Command.extend({
           })
         }
 
-        ipfs.config.show((err, config) => {
+        ipfs.config.get((err, config) => {
           if (err) {
             log.error(err)
             throw new Error('failed to read the config')
@@ -78,7 +78,7 @@ module.exports = Command.extend({
           })
         }
 
-        ipfs.config.show((err, originalConfig) => {
+        ipfs.config.get((err, originalConfig) => {
           if (err) {
             log.error(err)
             throw new Error('failed to read the config')

src/cli/commands/config/edit.js

@@ -25,7 +25,7 @@ module.exports = Command.extend({
       }
 
       function getConfig (next) {
-        ipfs.config.show((err, config) => {
+        ipfs.config.get((err, config) => {
           if (err) {
             log.error(err)
             next(new Error('failed to get the config'))

src/cli/commands/config/show.js

@@ -16,7 +16,7 @@ module.exports = Command.extend({
       if (err) {
         throw err
       }
-      ipfs.config.show((err, config) => {
+      ipfs.config.get((err, config) => {
         if (err) {
           throw err
         }

src/core/index.js

@@ -56,6 +56,7 @@ function IPFS (repoInstance) {
   this.block = block(this)
   this.object = object(this)
   this.libp2p = libp2p(this)
+  this.swarm = this.libp2p.swarm // for interface-ipfs-core sake
   this.files = files(this)
   this.cat = files(this).cat // Alias for js-ipfs-api cat
   this.bitswap = bitswap(this)

src/core/ipfs/config.js

@@ -1,14 +1,56 @@
 'use strict'
 
+const promisify = require('promisify-es6')
+const _get = require('lodash.get')
+const _set = require('lodash.set')
+
 module.exports = function config (self) {
   return {
-    // cli only feature built with show and replace
-    // edit: (callback) => {},
-    replace: (config, callback) => {
+    get: promisify((key, callback) => {
+      if (typeof key === 'function') {
+        callback = key
+        key = undefined
+      }
+
+      if (!key) {
+        return self._repo.config.get(callback)
+      }
+
+      if (typeof key !== 'string') {
+        return callback(new Error('Invalid key type'))
+      }
+
+      self._repo.config.get((err, config) => {
+        if (err) {
+          return callback(err)
+        }
+        const value = _get(config, key, undefined)
+        if (!value) {
+          callback(new Error('Key does not exist in config'))
+        } else {
+          callback(null, value)
+        }
+      })
+    }),
+    set: promisify((key, value, callback) => {
+      if (!key || typeof key !== 'string') {
+        return callback(new Error('Invalid key type'))
+      }
+
+      if (!value || Buffer.isBuffer(value)) {
+        return callback(new Error('Invalid value type'))
+      }
+
+      self._repo.config.get((err, config) => {
+        if (err) {
+          return callback(err)
+        }
+        _set(config, key, value)
+        self.config.replace(config, callback)
+      })
+    }),
+    replace: promisify((config, callback) => {
       self._repo.config.set(config, callback)
-    },
-    show: (callback) => {
-      self._repo.config.get(callback)
-    }
+    })
   }
 }

src/core/ipfs/id.js

@@ -14,11 +14,11 @@ module.exports = function id (self) {
 
     function ready () {
       callback(null, {
-        ID: self._peerInfo.id.toB58String(),
-        PublicKey: self._peerInfo.id.pubKey.bytes.toString('base64'),
-        Addresses: self._peerInfo.multiaddrs.map((ma) => { return ma.toString() }).sort(),
-        AgentVersion: 'js-ipfs',
-        ProtocolVersion: '9000'
+        id: self._peerInfo.id.toB58String(),
+        publicKey: self._peerInfo.id.pubKey.bytes.toString('base64'),
+        addresses: self._peerInfo.multiaddrs.map((ma) => { return ma.toString() }).sort(),
+        agentVersion: 'js-ipfs',
+        protocolVersion: '9000'
       })
     }
   }

src/http-api/index.js

@@ -38,7 +38,7 @@ exports = module.exports = function HttpApi (repo) {
         fs.writeFileSync(apiPath, 'api is on by js-ipfs', {flag: 'w+'})
       }
 
-      this.ipfs.config.show((err, config) => {
+      this.ipfs.config.get((err, config) => {
         if (err) {
           return callback(err)
         }

src/http-api/resources/config.js

@@ -60,7 +60,7 @@ exports.getOrSet = {
 
     if (value === undefined) {
       // Get the value of a given key
-      return request.server.app.ipfs.config.show((err, config) => {
+      return request.server.app.ipfs.config.get((err, config) => {
         if (err) {
           log.error(err)
           return reply({
@@ -84,7 +84,7 @@ exports.getOrSet = {
       })
     } else {
       // Set the new value of a given key
-      request.server.app.ipfs.config.show((err, originalConfig) => {
+      request.server.app.ipfs.config.get((err, originalConfig) => {
         if (err) {
           log.error(err)
           return reply({
@@ -113,8 +113,8 @@ exports.getOrSet = {
   }
 }
 
-exports.show = (request, reply) => {
-  return request.server.app.ipfs.config.show((err, config) => {
+exports.get = (request, reply) => {
+  return request.server.app.ipfs.config.get((err, config) => {
     if (err) {
       log.error(err)
       return reply({

src/http-api/resources/id.js

@@ -6,7 +6,16 @@ exports = module.exports
 
 exports.get = (request, reply) => {
   request.server.app.ipfs.id((err, id) => {
-    if (err) { return reply(boom.badRequest(err)) }
-    return reply(id)
+    if (err) {
+      return reply(boom.badRequest(err))
+    }
+
+    return reply({
+      ID: id.id,
+      PublicKey: id.publicKey,
+      Addresses: id.addresses,
+      AgentVersion: id.agentVersion,
+      ProtocolVersion: id.protocolVersion
+    })
   })
 }

src/http-api/routes/bootstrap.js

@@ -8,14 +8,14 @@ module.exports = (server) => {
 
   // https://github.com/ipfs/http-api-spec/blob/master/apiary.apib#L818
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/bootstrap',
     handler: resources.bootstrap.list
   })
 
   // https://github.com/ipfs/http-api-spec/blob/master/apiary.apib#L866
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/bootstrap/add',
     handler: resources.bootstrap.add,
     config: {
@@ -30,14 +30,14 @@ module.exports = (server) => {
 
   // https://github.com/ipfs/http-api-spec/blob/master/apiary.apib#L1081
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/bootstrap/list',
     handler: resources.bootstrap.list
   })
 
   // https://github.com/ipfs/http-api-spec/blob/master/apiary.apib#L1131
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/bootstrap/rm',
     handler: resources.bootstrap.rm,
     config: {

src/http-api/routes/config.js

@@ -19,7 +19,7 @@ module.exports = (server) => {
   api.route({
     method: '*',
     path: '/api/v0/config/show',
-    handler: resources.config.show
+    handler: resources.config.get
   })
 
   api.route({

src/http-api/routes/id.js

@@ -6,7 +6,7 @@ module.exports = (server) => {
   const api = server.select('API')
 
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/id',
     handler: resources.id.get
   })

src/http-api/routes/repo.js

@@ -7,7 +7,7 @@ module.exports = (server) => {
   const api = server.select('API')
 
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/repo',
     handler: resources.repo
   })

src/http-api/routes/swarm.js

@@ -6,31 +6,31 @@ module.exports = (server) => {
   const api = server.select('API')
 
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/swarm/peers',
     config: {
       handler: resources.swarm.peers.handler
     }
   })
 
   // api.route({
-  //   method: 'GET',
+  //   method: '*',
   //   path: '/api/v0/swarm/addrs',
   //   config: {
   //     handler: resources.swarm.addrs.handler
   //   }
   // })
 
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/swarm/addrs/local',
     config: {
       handler: resources.swarm.localAddrs.handler
     }
   })
 
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/swarm/connect',
     config: {
       pre: [
@@ -41,7 +41,7 @@ module.exports = (server) => {
   })
 
   // api.route({
-  //   method: 'GET',
+  //   method: '*',
   //   path: '/api/v0/swarm/disconnect',
   //   config: {
   //     handler: resources.swarm.disconnect
@@ -50,7 +50,7 @@ module.exports = (server) => {
 
   // TODO
   // api.route({
-  //  method: 'GET',
+  //  method: '*',
   //  path: '/api/v0/swarm/filters',
   //  config: {
   //    handler: resources.swarm.disconnect

src/http-api/routes/version.js

@@ -6,7 +6,7 @@ module.exports = (server) => {
   const api = server.select('API')
 
   api.route({
-    method: 'GET',
+    method: '*',
     path: '/api/v0/version',
     handler: resources.version.get
   })