Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: stalling subscription on (node) http-client when daemon is stopped #3468

Merged
merged 19 commits into from
Jun 1, 2021
Merged

fix: stalling subscription on (node) http-client when daemon is stopped #3468

merged 19 commits into from
Jun 1, 2021

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Dec 31, 2020 •
edited
Loading

This change fixes #3465 by throwing an error at the end of the subscription loop, which should not occur in normal circumstances because:

  1. If subscription was aborted that would have broken out of the loop so our error would not be thrown.
  2. If request that streams sub messages was closed from the outside that is an error that user should know and have a way to act upon.

@Gozala Gozala marked this pull request as draft December 31, 2020 23:37
@Gozala Gozala mentioned this pull request Dec 31, 2020
Closed
@Gozala Gozala mentioned this pull request Jan 6, 2021
Closed
@achingbrain achingbrain mentioned this pull request May 28, 2021
Merged
@achingbrain achingbrain changed the title WIP: Fix stalling subscribtion on (node) http-client when deamon is stopped. fix: stalling subscription on (node) http-client when daemon is stopped May 28, 2021
@achingbrain achingbrain marked this pull request as ready for review June 1, 2021 19:54
@achingbrain achingbrain merged commit 0266abf into master Jun 1, 2021
@achingbrain achingbrain deleted the fix/pubsub-subscribe-error branch June 1, 2021 19:55
achingbrain added a commit that referenced this pull request Jun 3, 2021
@achingbrain
fix: add onError to pubsub.subscripe types
8b17202 
This was missed in #3468.  Also runs the type checker on the pubsub
http client tests to ensure typing is correct.
@achingbrain achingbrain mentioned this pull request Jun 3, 2021
Merged
achingbrain added a commit that referenced this pull request Jun 4, 2021
@achingbrain
fix: add onError to pubsub.subscribe types (#3706)
d910aea 
This was missed in #3468.  Also runs the type checker on the pubsub http client
tests to ensure typing is correct.
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
@Gozala @achingbrain
fix: stalling subscription on (node) http-client when daemon is stopp…
bf88d98 
…ed (#3468)

This change fixes #3465 by upgrading to a temporary fork of node-fetch with
node-fetch/node-fetch#1172 applied.

Co-authored-by: achingbrain <alex@achingbrain.net>
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
@achingbrain
fix: add onError to pubsub.subscribe types (#3706)
a0f2b34 
This was missed in #3468.  Also runs the type checker on the pubsub http client
tests to ensure typing is correct.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client does not receive pubsub after api node reboots
2 participants
@Gozala @achingbrain