This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: switch to generated protobuf code for grpc-protocol #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json object emitted by protobufjs seems to be incompatible with it's own INamespace definition in the latest release so switch to using generated code. This should be a bit faster to load anyway.
|
I think we need protobufjs/protobuf.js#1115 to land in protobufjs before we can do this. |
achingbrain
added a commit
that referenced
this pull request
May 7, 2021
achingbrain
added a commit
that referenced
this pull request
May 7, 2021
* fix: reject requests when cors origin list is empty (#3674) If CORS origin list is empty, Hapi throws an error as it considers that to be invalid configuration. We want to reject requests that send and origin or a referer when no allowed origins have been configured, so when these headers are sent, reject the request if no allowed origins are present in the config. Co-authored-by: Vasco Santos <vasco.santos@moxy.studio> Co-authored-by: Marcin Rataj <lidel@lidel.org> * chore: ts-ignore until #3655 lands Co-authored-by: Vasco Santos <vasco.santos@moxy.studio> Co-authored-by: Marcin Rataj <lidel@lidel.org>
This was referenced Jun 21, 2023
This was referenced Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json object emitted by protobufjs seems to be incompatible with it's own INamespace definition in the latest release so switch to using generated code.
This should be a bit faster to load anyway.