This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: fix flaky test #3680
Merged
chore: fix flaky test #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the requests are initiated with `Promise.all`, there's no guarentee which order they arrive at the server in so when we check the responses, just make sure the length and contents are correct instead of the order.
This was referenced Mar 21, 2022
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Because the requests are initiated with `Promise.all`, there's no guarantee which order they arrive at the server in so when we check the responses, just make sure the length and contents are correct instead of the order.
This was referenced Dec 6, 2023
This was referenced Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the requests are initiated with
Promise.all, there's noguarantee which order they arrive at the server in so when we check
the responses, just make sure the length and contents are correct
instead of the order.