Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: typo in 'multiformats' type defs #3778

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix: typo in 'multiformats' type defs #3778

merged 3 commits into from
Jul 30, 2021

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 29, 2021

Fixes: #3776

It'd be nice to have some kind of tests that caught this, but that might mean adding typescript examples that use this which is probably a fair bit of work. @achingbrain thoughts?

@rvagg
Copy link
Member Author

rvagg commented Jul 30, 2021

whoa boy, that's uncovered a bunch of type failures in Actions, mostly where we're allowing strings in JS but our types are strict about CID

@achingbrain
Copy link
Member

We really need to do something. There is an example for using ipfs from ts but it doesn't catch this stuff, not 100% sure why not.

Adding types to the interface tests would probably help here but it's a big job.

Ref: ipfs/aegir#849

@rvagg
Copy link
Member Author

rvagg commented Jul 30, 2021

k, so the change here is to go with the strict CID requirement and remove the option to provide strings in these places. SGTM although it'll be interesting to see user feedback as more people start adopting the latest and find their flexibility removed.

@achingbrain achingbrain merged commit 1bf35f8 into master Jul 30, 2021
@achingbrain achingbrain deleted the rvagg/multiformts branch July 30, 2021 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiformats import error in typescript
2 participants