This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: typo in 'multiformats' type defs #3778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoa boy, that's uncovered a bunch of type failures in Actions, mostly where we're allowing strings in JS but our types are strict about |
We really need to do something. There is an example for using ipfs from ts but it doesn't catch this stuff, not 100% sure why not. Adding types to the interface tests would probably help here but it's a big job. Ref: ipfs/aegir#849 |
k, so the change here is to go with the strict CID requirement and remove the option to provide strings in these places. SGTM although it'll be interesting to see user feedback as more people start adopting the latest and find their flexibility removed. |
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3776
It'd be nice to have some kind of tests that caught this, but that might mean adding typescript examples that use this which is probably a fair bit of work. @achingbrain thoughts?