This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Refactor cli to use yargs #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subscribing! |
|
Why not minimist? |
|
Because minimist is similarly to ronin not really maintained anymore at the moment. |
|
@dignifiedquire Can we talk to someone about that? Maybe @substack would be interested in handing it over to someone, or something? |
dignifiedquire
changed the title
|
This is now ready for review @RichardLitt @diasdavid All failing tests are as far as I can see from the duplexify issues, but will wait for CI to confirm that. |
dignifiedquire
force-pushed
the
better-cli
branch
from
e17cb3f
to
1771ce3
Compare
Closed
| updateNotifier({ | ||
| pkg, | ||
| updateCheckInterval: 1000 * 60 * 60 * 24 * 7 // 1 week | ||
| }).notify() |
|
Does this solve the 'help text' issue for the commands? |
dignifiedquire
force-pushed
the
better-cli
branch
from
ac629ea
to
a351eb0
Compare
yes |
dignifiedquire
force-pushed
the
better-cli
branch
2 times, most recently
from
c2ff344
to
7510fdf
Compare
|
@diasdavid getting green, please review :) |
dignifiedquire
force-pushed
the
better-cli
branch
from
5440bf3
to
b595eaa
Compare
|
New output > node src/cli/bin.js files --help
src/cli/bin.js files
Commands:
add <file> Add a file to IPFS using the UnixFS
data format
cat <ipfs-path> Download IPFS objects
get <ipfs-path> Download IPFS objects
Options:
--help Show help [boolean]
> node src/cli/bin.js files add --help
src/cli/bin.js files add <file>
Options:
--help Show help [boolean]
--recursive, -r [boolean] [default: false] |
|
nice, just tried it out, I like it :) let's merge it it :) |
|
@RichardLitt how is the ipfs mans coming along? |
|
I haven't had much bandwidth for this since getting back. :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the cli interface a little bit more awesome :)
roninwithyargs, closes cli: doc: OPTIONS output not working #331versioncommand to return the actual version ofjs-ipfsnot the version in the config. Closesjsipfs versionshould work without any ipfs repo #377