Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Switch from IPFS_REUSEPORT to LIBP2P_TCP_REUSEPORT #3955

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

aschmahmann
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Nov 29, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann
Copy link
Contributor Author

@achingbrain any idea why this PR is failing, is it just flakiness/pre-existing failures or something new here? The LIBP2P_TCP_REUSEPORT env var has been around in go-libp2p for a few years and they're now dropping support for IPFS_REUSEPORT (libp2p/go-tcp-transport#104)

@achingbrain
Copy link
Member

Looks like a regression was caused by libp2p/js-libp2p-crypto#202

@achingbrain
Copy link
Member

Actually on closer inspection this is caused by multiple versions of libp2p-crypto in the dep tree.

#3947 brings it all into line, though it needs releases of:

@achingbrain achingbrain merged commit c936ed5 into master Dec 3, 2021
@achingbrain achingbrain deleted the fix/reuseport-env-var branch December 3, 2021 14:53
achingbrain added a commit that referenced this pull request Dec 3, 2021
achingbrain added a commit that referenced this pull request Dec 3, 2021
The `LIBP2P_TCP_REUSEPORT` env var has been around in go-libp2p for a few years and they're now dropping support  for IPFS_REUSEPORT (libp2p/go-tcp-transport#104)

Co-authored-by: achingbrain <alex@achingbrain.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants