Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: BWOptions.interval accepts number|string #4061

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Mar 3, 2022

fix #3985

@SgtPooki SgtPooki requested review from achingbrain and lidel March 3, 2022 19:02
@SgtPooki SgtPooki self-assigned this Mar 3, 2022
@SgtPooki SgtPooki added the status/in-progress In progress label Mar 3, 2022
@SgtPooki
Copy link
Member Author

SgtPooki commented Mar 3, 2022

@lidel these tests seem to be failing unrelated to my changes. However, I couldn't get npm install to succeed locally; I assumed due to M1 issues 😬

@achingbrain
Copy link
Member

I have an M1, things install fine for me - what's the error message you are seeing on install?

The build is failing because during the esbuild step it's hitting this line and failing to resolve the node 'path' module.

This is likely because something in the dep tree had it previously and now does not which means it only worked previously by coincidence. Oops.

The quick fix is either to add the path polyfill to aegir or to add "path": false to the browser overrides, but the better fix might be to work out why the resolve module is getting referenced during the browser build in the first place since it should only really be loaded from node.

@lidel lidel added the need/author-input Needs input from the original author label Mar 11, 2022
@BigLep
Copy link
Contributor

BigLep commented Mar 18, 2022

@SgtPooki : can you please respond with next steps so we can close this or get it across the line?

@achingbrain achingbrain merged commit e90b8f1 into ipfs:master Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/author-input Needs input from the original author status/in-progress In progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs-core-types@0.9.0 - Out of date types for BWOptions
4 participants