This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: update car dependency for CARv2 read support #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Apr 20, 2022
|
Thanks! |
achingbrain
changed the title
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 31, 2022
This was referenced May 31, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 30, 2022
This was referenced Oct 16, 2022
This was referenced Oct 17, 2022
This was referenced Apr 24, 2023
This was referenced Jun 24, 2023
This was referenced Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.x adds basic CARv2 read support, so you could
ipfs dag importa CARv2 with this; also with https://explore.ipld.io/ getting CAR support, this would allow importing and inspection of a CARv2 there.The breakage was in the return type definition of
CarReader#header()which I don't believe is touched in js-ipfs, which only cares aboutgetRoots()in the header which remains the same.